feat: clean node_modules before building subgraph #884
Conversation
The idea is to remove the prepublish script from the scripts object of the package.json file of every cli template when the template is downloaded using the CLI. BREAKING CHANGE: n
… readFileSync again
feat: clean node_modules before building subgraph
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
There was a problem hiding this comment.
Hey @0xshikhar thank you very much for this PR. I just left one comment.
| "clean:subgraph": "rimraf apps/subgraph/node_modules", | ||
| "build:subgraph": "yarn clean:subgraph && yarn workspace semaphore-subgraph build:sepolia", |
There was a problem hiding this comment.
I think this issue is solved with these two lines. Why it is necessary to add clean:branch and update the workspaces object?
There was a problem hiding this comment.
i think it was a testing error as i checking for test cases - clean:branch is not needed at all.
There was a problem hiding this comment.
hi @vplasencia, let me know if there is any update.
| "nohoist": [ | ||
| "**/semaphore-subgraph/**" | ||
| ] |
There was a problem hiding this comment.
Why is it necessary to add this section? It looks like the changes in the script work well and solve the issue.
fix(subgraph): clean node_modules before building subgraph
Related Issue(s)
Closes: Issue#876
Other information
Checklist
yarn formatandyarn lintwithout getting any errors