Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add benchmarks page #889

Merged
merged 2 commits into from
Oct 30, 2024
Merged

docs: add benchmarks page #889

merged 2 commits into from
Oct 30, 2024

Conversation

vplasencia
Copy link
Member

@vplasencia vplasencia commented Oct 29, 2024

Description

This PR:

  • Adds the benchmarks page to the Semaphore documentation.

  • Updates the docusaurus version because there was a warning in the console that was solved by using the latest docusaurus version.

Warning before updating the docusaurus version:

LoadableComponent uses the legacy contextTypes API which is no longer supported and will be removed in the next major release. Use React.createContext() with static contextType instead.

Related Issue(s)

Closes #815

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you vm @vplasencia! LGTM :)

@vplasencia vplasencia merged commit 9b419f0 into main Oct 30, 2024
5 checks passed
@vplasencia vplasencia deleted the docs/add-benchmarks-page branch October 30, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a page in the doc to list all benchmarks
2 participants