fix: expose temp file with environment variables in Windows #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/renderedtext/tasks/issues/6922
Issue
Since we don't need the temporary file containing the environment variables in Windows (no PTY), we are not creating that file. That is an issue for Windows debug jobs which cannot access those values in any way.
Solution
Create the file for Windows jobs too. The file will be created in the
$env:Tempdirectory, usuallyC:\Users\<username>\AppData\Local\Temp. The file is created with a.ps1extension and uses the PowerShell format for defining environment variables, so the user can "source" it as well.Note:
sourceis not available in PowerShell, but you can do something like. <script-name>.ps1