Recalculate suite duration only when it makes sense #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipi
force-pushed
the
mk/fix-aggregated-durations
branch
4 times, most recently
from
3b132c5 to
6587f8e
Compare
skipi
force-pushed
the
mk/fix-aggregated-durations
branch
from
6587f8e to
42da893
Compare
skipi
force-pushed
the
mk/fix-aggregated-durations
branch
from
42da893 to
1260982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug occurs when reconstructing test results from multiple files. In this case, each test suite is being created from scratch. As a result, CLI properly calculated the duration after adding the first test to the suite. However, any subsequent test addition didn't change the suite duration whatsoever(since we don't want to modify test-runner supplied durations when possible).
This PR introduces a check that ensures proper(larger) duration is used when merging multiple job files.