Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ansible directory path inside repo #2766

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

tjhowse
Copy link
Contributor

@tjhowse tjhowse commented Feb 23, 2025

Implements #2733. Allows for a repo to be configured with an optional relative path from the Git root to the location inside the repo that stores the playbooks, role directory and configuration.

I'm aware of some blocking tasks:

  1. Complete the "isValidPath()" validator,
  2. Work out the best place to suffix the path onto the repo location,
  3. Update the docs,
    4. Handle DB migration.

@tjhowse
Copy link
Contributor Author

tjhowse commented Feb 26, 2025

I think the CI needs a cache clear. An earlier mistake in my DB migration script tainted the cache with the new column with incorrect constraints. The CI is trying to migrate an already-migrated DB.

Edit: Maybe not? I think I've just misunderstood how the migration system works. It's OK now.

@@ -31,6 +31,7 @@ type Repository struct {
SSHKeyID int `db:"ssh_key_id" json:"ssh_key_id" binding:"required" backup:"-"`

SSHKey AccessKey `db:"-" json:"-" backup:"-"`
Path string `db:"path" json:"path" backup:"-"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backup:"-" - must be backup:"path".

@fiftin
Copy link
Collaborator

fiftin commented Feb 26, 2025

Currently Playbook Filename can be path to the file. What reason to have path field?

Perhaps it is documentation issue?

Perhaps path must be in Repository table?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants