-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create graygelf in constructor once vs on every call to eventHandler #222
Conversation
Ping @adnanrahic, @megastef can we merge & release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adnanrahic Yeah, I almost did this assuming the other was pushed but figured it was better to do them both right off master. Will do as you suggest... should be sorted in a sec. |
78fb0ef
to
a7a11c4
Compare
a7a11c4
to
9a96990
Compare
@adnanrahic Whew, I should never do this stuff before morning coffee! But I should have it sorted. Let me know if you see any issues. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Oh yeah, I understand all too well. I'll go ahead and merge this right away, and release a new version today. 👌
Thanks again @hkclark for taking the time to fix this issue. Hope you enjoy using Logagent. Feel free to reach out or open new issues if you come across any bugs. 😄 |
@adnanrahic Terrific! Thank you so much for the help. We are looking forward to using logagent.js -- it's got some really great features and a nice, lightweight footprint. Many thanks! |
Thank you for your kind words, @hkclark! |
Yeah, we use a private Github Enterprise and a bunch of other private git repos at work, so I haven't done much on the public side of things. :-) |
Ah, and I thought we were your first love ;) |
LOL :-) |
Here is a Pull Request that fixes the leak with graygelf for me. Let me know if there are any questions or comments or if I can do anything to help. Thanks!