fix(kotlin): classes with newlines

[brandonspark]

What:

This PR makes it so we can parse Kotlin classes that have a newline between the class identifier and constructor.

Why:

Parse rate.

How:

The problem is in cases like:

class Foo
constructor Bar() { ... }

Here, we insert an automatic semicolon between Foo and constructor. This leaves us able to parse class Foo as a class_declaration, but constructor Bar ... is not allowed on its own.

We simply allow constructor Bar ... to be a standalone statement, and resolve to stitch them together at parsing time.

Testing

Tested with make test and test-lang kotlin

Security

• Change has no security implications (otherwise, ping the security team)

[amchiclet]

FYI make lang in Circle CI runs out of memory when parsing C sharp. Ran it locally, and it passed.

[nmote]

Not a fan of all the formatting changes in the tests. I guess the "hide whitespace" setting only has to do with whitespace changes on a single line, so to review, one still has to compare these manually.

I spot-checked some and they looked the same, but I'm assuming with this review that the only behavior change is for the added test cases.

[amchiclet]

Also spot checked and arrived at the same conclusion. The only behavior change is the new test cases.

Thanks for the quick review!

[brandonspark]

Not a fan of all the formatting changes in the tests. I guess the "hide whitespace" setting only has to do with whitespace changes on a single line, so to review, one still has to compare these manually.

I spot-checked some and they looked the same, but I'm assuming with this review that the only behavior change is for the added test cases.

the formatting changes are automatically generated from tree-sitter test -u. it's a pain, but this slight annoyance in review now will make future reviews easier.

[nmote]

In the future, I'd prefer reformatting to be split into a separate PR