Circom grammar update #511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mjambon is in the middle of a big refactoring in ocaml-tree-sitter-semgrep but once his PR is merged we can probably merge this one. |
|
@mjambon can we merge this? Are you done with your tree-sitter version refactoring? |
|
Hi, any updates on merging this? |
aryx
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Sorry for the late review, we had an offsite last week.
Can you add some test corpus for those new supported constructs?
Also was it possible instead to modify the original grammar so that
we don't have to copy so much from main_component_definition and component_declaration?
like if you introduce an intermediate rule for what is after the =, like main_component_value, then it's possible to override just that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating tree-sitter and semgrep grammar for circom language.