Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kotlin #516

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

update kotlin #516

wants to merge 1 commit into from

Conversation

brandonspark
Copy link
Contributor

@brandonspark brandonspark commented Oct 16, 2024

This PR updates the Kotlin grammar.

More than a year ago, we decided to fork the tree-sitter-kotlin repo because the maintainers were being unresponsive, and we wanted slightly better parsing behavior. Now, it seems that the repository is being actively maintained, so I think we can safely go back to the regular Kotlin repo. (we also want their changes)

Checklist

  • Any new parsing code was already published, integrated, and merged into Semgrep. DO NOT MERGE THIS PR BEFORE THE SEMGREP INTEGRATION WORK WAS COMPLETED.
  • Change has no security implications (otherwise, ping the security team)

@brandonspark brandonspark requested a review from a team as a code owner October 16, 2024 23:27
@brandonspark brandonspark requested a review from kopecs October 16, 2024 23:27
@brandonspark brandonspark marked this pull request as draft October 16, 2024 23:27
@brandonspark
Copy link
Contributor Author

blocked on fwcd/tree-sitter-kotlin#156, which will implement what @emjin did in semgrep/tree-sitter-kotlin@1e57b1b upstream

@aryx
Copy link
Collaborator

aryx commented Oct 17, 2024

How do you know he is more responsive?

@brandonspark
Copy link
Contributor Author

How do you know he is more responsive?

the repo was updated recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants