Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Switch to poetry and publish pypi package #44

Merged
merged 16 commits into from
Sep 4, 2020
Merged

Switch to poetry and publish pypi package #44

merged 16 commits into from
Sep 4, 2020

Conversation

brendongo
Copy link
Member

No description provided.

@brendongo brendongo changed the title Switch to poetry and publish pypi package WIP: Switch to poetry and publish pypi package Aug 27, 2020
@brendongo brendongo linked an issue Aug 27, 2020 that may be closed by this pull request
Publish semgrep-agent to pypi #30
Closed
@brendongo brendongo changed the title WIP: Switch to poetry and publish pypi package Switch to poetry and publish pypi package Aug 28, 2020
@brendongo
Copy link
Member Author

Still need to update development instructions

@brendongo
Copy link
Member Author

Because of python-poetry/poetry#2711 poetry does not work when you want to use python 3.8
Because of python-poetry/poetry#2876 we cannot use the suggested fix of using beta release 1.1.0b1

Will make semgrep-agent 3.7 compliant

@brendongo
Copy link
Member Author

Note that with this semgrep version will need to be bumped in pyproject.toml when updating the docker image.
This is so that semgrep can be listed as a dependency in the pypi published semgrep-agent. Alternatively we can have users come with their own semgrep installation. Figure it's less headache to have semgrep as a python dependency.

underyx
underyx reviewed Sep 4, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
underyx
underyx reviewed Sep 4, 2020
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
underyx
underyx reviewed Sep 4, 2020
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@underyx
Copy link
Member

underyx commented Sep 4, 2020

Note the merge conflict after the absolute imports change 😇

underyx
underyx reviewed Sep 4, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
underyx
underyx reviewed Sep 4, 2020
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
underyx
underyx approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@underyx underyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wheeeeeeee

@brendongo brendongo merged commit 9a7c54b into develop Sep 4, 2020
@brendongo brendongo deleted the brendon/poetry branch September 4, 2020 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@underyx underyx underyx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish semgrep-agent to pypi
2 participants
@brendongo @underyx