Merge pull request #3010 from returntocorp/fixcorrectness

Lower correctness to INFO
semgrep · Jul 25, 2023 · 56817b0 · 56817b0
2 parents 56569db + c712edc
commit 56817b0
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/go/lang/correctness/useless-eqeq.yaml b/go/lang/correctness/useless-eqeq.yaml
@@ -10,7 +10,7 @@ rules:
       Detected useless comparison operation `$X == $X` or `$X != $X`. This will always return 'True' or 'False' and therefore
       is not necessary. Instead, remove this comparison operation or use another comparison expression that is not deterministic.
     languages: [go]
-    severity: ERROR
+    severity: INFO
     metadata:
       category: correctness
       technology:
@@ -21,7 +21,7 @@ rules:
       not necessary in the code. Remove the 'if (False)' expression completely or just the 'if (True)' comparison depending
       on which expression is in the code.
     languages: [go]
-    severity: ERROR
+    severity: INFO
     pattern-either:
       - pattern: if (true) { ... }
       - pattern: if (false) { ... }

diff --git a/javascript/lang/correctness/useless-assign.yaml b/javascript/lang/correctness/useless-assign.yaml
@@ -11,7 +11,7 @@ rules:
     languages:
       - javascript
       - typescript
-    severity: WARNING
+    severity: INFO
     metadata:
       category: correctness
       technology:

diff --git a/javascript/lang/correctness/useless-eqeq.yaml b/javascript/lang/correctness/useless-eqeq.yaml
@@ -14,7 +14,7 @@ rules:
     languages:
       - javascript
       - typescript
-    severity: ERROR
+    severity: INFO
     metadata:
       category: correctness
       technology:

diff --git a/python/lang/maintainability/useless-assign-keyed.yaml b/python/lang/maintainability/useless-assign-keyed.yaml
@@ -2,7 +2,7 @@ rules:
   - id: useless-assignment-keyed
     message: key `$Y` in `$X` is assigned twice; the first assignment is useless
     languages: [python]
-    severity: WARNING
+    severity: INFO
     pattern-either:
       - pattern: |
           $X[$Y] = ...