chore: use deepok to mark lines as ok when run with the pro engine #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have deepruleid to mark lines as matching only with the pro engine, but we didn't have anything to mark lines as ok only with the pro engine. deepok is intended for that. This PR updates annotations to use deepok.
|
Failing tests are validation errors, appear unrelated (they're probably due to Brandon's changes) |
|
yep, seems like the validation errors are unrelated and historical isn't passing bc of some type inference checks. Lgtm -- thanks emma! |
colleend
approved these changes
Jun 26, 2023
|
I merged all the latest changes in develop (including Brandon's changes to regex metavars capture), but tests are still reported as failing. Is that expected? |
|
nope, that's not expected -- I suspect that this is because I can look into it for a bit 👍 edit: yep: |
|
Oh no, --test must check it differently. I could change the format of this annotation if that would be the simplest way |
5 tasks
emjin
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Jun 27, 2023
This will help solve: semgrep/semgrep-rules#2985. Adds parsing of notations like `ruleid: deepok: foobar` and `ruleid: deepruleid: foobar`. _To Test:_ Run `python -m semgrep --test semgrep-rules/java/spring/security/injection` PR checklist: - [X] Purpose of the code is [evident to future readers](https://semgrep.dev/docs/contributing/contributing-code/#explaining-code) - [x] Tests included or PR comment includes a reproducible test plan - [x] Documentation is up-to-date - [x] A changelog entry was [added to changelog.d](https://semgrep.dev/docs/contributing/contributing-code/#adding-a-changelog-entry) for any user-facing change - [x] Change has no security implications (otherwise, ping security team) If you're unsure about any of this, please see: - [Contribution guidelines](https://semgrep.dev/docs/contributing/contributing-code)! - [One of the more specific guides located here](https://semgrep.dev/docs/contributing/contributing/)
|
passes develop now! I will merge :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have deepruleid to mark lines as matching only with the pro engine, but we didn't have anything to mark lines as ok only with the pro engine. deepok is intended for that.
This PR updates annotations to use deepok.