Add new rule for flask-route-decorator #3244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This comment was marked as outdated.
This comment was marked as outdated.
|
I signed the CLA but that message doesn't get resolved for some reason. |
|
It looks like Semgrep does not take the order of decorators into account currently: https://semgrep.dev/playground/s/pKLAZ While your regex is a nice workaround, I am reporting this as a bug/feature request so that we can avoid complex regexes for this. There are other route decorators in Flask besides the I've annotated a few more things you should change for the CI checks to pass. |
0xDC0DE
requested changes
Jan 9, 2024
| def f(): | ||
| pass | ||
|
|
||
| # ok: Correct order |
| def f(): | ||
| pass | ||
|
|
||
| # ok: "func" not "route" |
| def f(): | ||
| pass | ||
|
|
||
| # ok: Correct order with app |
| def f(): | ||
| pass | ||
|
|
||
| # ok: 2 routes are independent |
Co-authored-by: Pieter De Cremer (Semgrep) <pieter@r2c.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wahoo! New published rules with khanhldt.pnbj from @khanhldt.
See semgrep.dev/s/2ZJ3Y for more details.
Thanks for your contribution! ❤️