Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Published Rules - uniswap.npm-package-in-action-not-pinned-to-commit-sha #3270

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

semgrep-dev-pr-bot[bot]
Copy link
Contributor

Wahoo! New published rules with uniswap.npm-package-in-action-not-pinned-to-commit-sha from @morgan.roman@uniswap.org.

See semgrep.dev/s/RelOq for more details.

Thanks for your contribution! ❤️

@mr-uniswap
Copy link

Special thanks to @kurt-r2c

@0xDC0DE
Copy link
Contributor

0xDC0DE commented Jan 12, 2024

It looks like the rule was deleted again by the testcode.

Currently the CI thinks the testcode is an invalid Semgrep rule.
Typically for rules targetting yaml code, we use the extension .test.yaml for the testcode. Example here: https://github.com/semgrep/semgrep-rules/tree/develop/yaml/argo/security

@kurt-r2c
Copy link
Contributor

Opened a bug for this publish issue - it looks like we don't create PRs for YAML-targeted stuff correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants