Add PHP base-convert-loses-precision #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function base_convert uses 64-bit numbers internally, and does not correctly convert large numbers. It is not suitable for random tokens such as those used for session tokens or CSRF tokens.
0xDC0DE
approved these changes
Feb 19, 2024
p4p3r
reviewed
Feb 19, 2024
| $command = $secret = $counter = $uid = $totalColors = $i = $row = $value = $numeric = $string = '1'; | ||
| $getRandomNumber = 'rand'; | ||
|
|
||
| // ok: base-convert |
There was a problem hiding this comment.
@Sjord all you annotations are using the wrong rule id: they should use base-convert-loses-precision.
That's why the CI check is failing :)
There was a problem hiding this comment.
Thanks. I fixed it. I renamed the rule to give it a more specific name, but apparently did not replace all occurrences.
0xDC0DE
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Add PHP base-convert-loses-precision The function base_convert uses 64-bit numbers internally, and does not correctly convert large numbers. It is not suitable for random tokens such as those used for session tokens or CSRF tokens. * PHP base-convert-loses-precision: Correctly name rule in test Co-authored-by: Sjoerd Langkemper <sjoerd-github@linuxonly.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function base_convert uses 64-bit numbers internally, and does not correctly convert large numbers. It is not suitable for random tokens such as those used for session tokens or CSRF tokens.