Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing rule that detects just parameter names #3344

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

6f6d6172
Copy link

Hi folks,

It's me deleting another rule. This time it's a rule that basically flags specific parameter names as a high severity finding. I get what it's going for but this rule isn't really useful, especially when the guidance is "don't use those parameters". This rule can't tell if you're using the parameters safely or not, and the guidance might cause someone who was doing something safely to do something more dangerous (e.g. using params[:account_id] instead of params.permit(...) and assigning it manually to a model).

Regarding the "spirit" of what this rule is trying to detect, I don't think it's possible without doing some sort of control flow analysis. While it's a different tool entirely, I've had success using this Rubocop rule I wrote a couple years ago.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants