removing rule that detects just parameter names #3344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
It's me deleting another rule. This time it's a rule that basically flags specific parameter names as a high severity finding. I get what it's going for but this rule isn't really useful, especially when the guidance is "don't use those parameters". This rule can't tell if you're using the parameters safely or not, and the guidance might cause someone who was doing something safely to do something more dangerous (e.g. using
params[:account_id]
instead ofparams.permit(...)
and assigning it manually to a model).Regarding the "spirit" of what this rule is trying to detect, I don't think it's possible without doing some sort of control flow analysis. While it's a different tool entirely, I've had success using this Rubocop rule I wrote a couple years ago.