Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow OWASP Top 10 references from Kubernetes and LLM Top 10 #3499

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Allow OWASP Top 10 references from Kubernetes and LLM Top 10 #3499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions yaml/semgrep/metadata-owasp.test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,22 @@ rules:
metadata:
# ok: metadata-owasp
owasp: A05:2021 - Security Misconfiguration
- id: example-k8s-1
message: Example
severity: ERROR
languages: [json, yaml]
pattern: "..."
metadata:
# ok: metadata-owasp
owasp: "K1: Insecure Workload Configurations"
- id: example-k8s-1b
message: Example
severity: ERROR
languages: [json, yaml]
pattern: "..."
metadata:
# ok: metadata-owasp
owasp: K01:2022 - Insecure Workload Configurations
- id: example-bad-zero
message: Example
severity: ERROR
Expand Down Expand Up @@ -75,6 +91,8 @@ rules:
- A05:2021 - Security Misconfiguration
# ok: metadata-owasp
- A06:2017 - Security Misconfiguration
# ok: metadata-owasp
- K01:2022 - Insecure Workload Configurations
- id: example-bad-list
message: Example
severity: ERROR
Expand Down
8 changes: 4 additions & 4 deletions yaml/semgrep/metadata-owasp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ rules:
- id: metadata-owasp
message: >-
The `owasp` tag in Semgrep rule metadata should start with the format "A00:YYYY",
where A00 is the OWASP top ten number and YYYY is the OWASP top ten year.
where A00 is the OWASP Top 10 number and YYYY is the OWASP Top 10 year.
severity: ERROR
languages: [json, yaml]
patterns:
Expand All @@ -13,13 +13,13 @@ rules:
# If there's a year, need leading zero, e.g. `A01:2021 blah` rather than `A1:2021 blah`.
- patterns:
- pattern: 'owasp: "..."'
- pattern-not: 'owasp: "=~/^A(0?[1-9]|10):\s+.+$/"'
- pattern-not: 'owasp: "=~/^A(0[1-9]|10):([0-9]{4})?\s+.+$/"'
- pattern-not: 'owasp: "=~/^(A|K|LLM)(0?[1-9]|10):\s+.+$/"'
- pattern-not: 'owasp: "=~/^(A|K|LLM)(0[1-9]|10):([0-9]{4})?\s+.+$/"'
# A list, must have the year, e.g. `- A01:2021 blah`
- patterns:
- pattern-inside: "owasp: [...]"
- pattern: '"$ANYTHING"'
- pattern-not-regex: .*A(0[1-9]|10):[0-9]{4}\s+.*
- pattern-not-regex: .*(A|K|LLM)(0[1-9]|10):[0-9]{4}\s+.*
- pattern-not-regex: "owasp:"
metadata:
category: best-practice
Expand Down