Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Develop into Release #3510

Merged
merged 30 commits into from
Nov 4, 2024
Merged

Merge Develop into Release #3510

merged 30 commits into from
Nov 4, 2024

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    b756568 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. PHP tainted exec (#3468)

    * PHP tainted exec
    
    When user input is passed to a function that executes a shell command, without
    escaping.
    
    * Correct message string YAML operator
    
    Co-authored-by: Pieter De Cremer (Semgrep) <pieter@r2c.dev>
    
    ---------
    
    Co-authored-by: Pieter De Cremer (Semgrep) <pieter@r2c.dev>
    Co-authored-by: Lewis <LewisArdern@live.co.uk>
    3 people authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6d1b466 View commit details
    Browse the repository at this point in the history
  2. Upload dockerd socket mount detection rule and test file (#3360)

    * Upload dockerd socket mount detection rule and test file
    
    * Update dockerd-socket-mount.dockerfile
    
    * Update documentbuilderfactory-disallow-doctype-decl-missing.yaml
    
    Update the rule for checking if FEATURE_SECURE_PROCESSING is set to TRUE for DocumentBuilderFactory object.
    
    * Revert "Update documentbuilderfactory-disallow-doctype-decl-missing.yaml"
    
    This reverts commit c1e2281.
    
    ---------
    
    Co-authored-by: Pieter De Cremer (Semgrep) <pieter@r2c.dev>
    r0075h3ll and 0xDC0DE authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7427b82 View commit details
    Browse the repository at this point in the history
  3. Switch to osemgrep test --experimental (from 3min to 21s) (#3472)

    * Switch to osemgrep test --experimental
    
    test plan:
    wait for green CI check
    
    * comment
    
    * comments
    aryx authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    be389ac View commit details
    Browse the repository at this point in the history
  4. remove fingerprints/fingerprints.yaml (#3474)

    * remove fingerprints/fingerprints.yaml
    
    No idea what this file is, but it's annoying because
    we have to skip it in many scripts because it does not
    contain regular rules and target test files.
    Let's just remove it to simplify things.
    
    test plan:
    wait for green CI checks
    
    * remove every use of fingerprints (each time it was to skip the dir)
    aryx authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    46fc340 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. chore: Fix some wrong annotations (#3476)

    test plan:
    osemgrep test on those dirs do not report any more warnings
    about wrong annotations
    aryx authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8ce8781 View commit details
    Browse the repository at this point in the history
  2. Run osemgrep test --pro on apex/ and elixir/ too (#3478)

    test plan:
    wait for green CI checks
    aryx authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    de1405b View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Named metavariable bug was fixed (#3477)

    * Named metavariable bug for CMD-like instructions using array syntax was fixed
    
    * Update the expected autofixes
    mjambon authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    959c893 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81e40c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. run osemgrep validate --pro (#3481)

    test plan:
    osemgrep validate --pro .
    aryx authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ecba02c View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Rule: OpenAI isConsequential flag set to false for state changing ope…

    …ration in OpenAPI spec (#3446)
    
    * Rule: OpenAI isConsequential flag set to false for state changing operation in OpenAPI spec
    
    * set subcategory to audit instead of vuln
    
    * alternative approach
    
    ---------
    
    Co-authored-by: Pieter De Cremer (Semgrep) <pieter@r2c.dev>
    aabashkin and 0xDC0DE authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    ed75fb1 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Include GitHub discussions as user input source. (#3483)

    Co-authored-by: Vasilii Ermilov <inkz@xakep.ru>
    bananabr and inkz authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6364d2b View commit details
    Browse the repository at this point in the history
  2. Exclude Slack webhook sample URL (#3482)

    * Exclude Slack webhook sample URL.
    
    * Test case for excluding Slack webhook sample URL.
    
    ---------
    
    Co-authored-by: Vasilii Ermilov <inkz@xakep.ru>
    dbarlett and inkz authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ca45011 View commit details
    Browse the repository at this point in the history
  3. New Published Rules - semgrep.check-is-none-explicitly (#3480)

    * add semgrep/check-is-none-explicitly.yaml
    
    * add semgrep/check-is-none-explicitly.py
    
    * move new rule to correctness directory
    
    ---------
    
    Co-authored-by: Clara McCreery <clara@semgrep.com>
    Co-authored-by: Vasilii <inkz@xakep.ru>
    3 people authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5aa4f20 View commit details
    Browse the repository at this point in the history
  4. todoruleid: -> proruleid: for solidity test (#3484)

    test plan:
    osemgrep test --pro solidity
    aryx authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    0da2dce View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    b4eb008 View commit details
    Browse the repository at this point in the history
  2. Add rules around Node.js crypto module (#3357)

    Co-authored-by: Pieter De Cremer (Semgrep) <pieter@r2c.dev>
    Starkteetje and 0xDC0DE authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c865e0c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    153588f View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    cd697bc View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Fix for osemgrep test --pro with DeepScan too (often deepruleid: -> d…

    …eeptodoruleid:) (#3490)
    
    * Fix for osemgrep test --pro with DeepScan too
    
    Mostly some deepruleid: -> deeptodoruleid: as unfortunately
    the engine is still not good enough to find them
    
    test plan:
    osemgrep-pro test --pro .
    
    * fix
    aryx authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5583c92 View commit details
    Browse the repository at this point in the history
  2. Revert "Fix for osemgrep test --pro with DeepScan too (often deeprule…

    …id: -> deeptodoruleid:) (#3490)" (#3491)
    
    This reverts commit 5583c92.
    aryx authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    966d1ba View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Fix annots for osemgrep test --pro with DeepScan (#3492)

    test plan:
    osemgrep-pro test --pro semgrep-rules/
    aryx authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    97bd5b0 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Remove scripts/run-test to simplify, call just osemgrep test (#3493)

    * Remove scripts/run-test to simplify, call just osemgrep test
    
    It has been almost a month that we run both osemgrep test
    and pysemgrep --test and no complaints, so let's remove
    the use of pysemgrep --test so we can then remove the
    corresponding python code in pysemgrep.
    
    test plan:
    make validate
    make test-only
    wait for green CI checks
    
    * more
    aryx authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0bba56c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. remove redundant rules for HTML templates (#3349)

    * remove redundant rules for HTML templates
    
    * Delete python/django/security/audit/xss/var-in-script-tag.html
    
    * Delete python/django/security/audit/xss/var-in-script-tag.yaml
    
    ---------
    
    Co-authored-by: Claudio <claudio@r2c.dev>
    inkz and p4p3r authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    aa55fb5 View commit details
    Browse the repository at this point in the history
  2. Update stacktrace-disclosure rule and test (#3495)

    * Update stacktrace-disclosure.cs
    
    * Update stacktrace-disclosure.yaml
    p4p3r authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e91dd3f View commit details
    Browse the repository at this point in the history
  3. Remove redundant rule python.lang.security.audit.ftplib (#3496)

    * Remove redundant rule python.lang.security.audit.ftplib
    
    python.lang.security.audit.ftplib.ftplib is best replaced by  python.lang.security.audit.insecure-transport.ftplib.use-ftp-tls.use-ftp-tls
    
    * Update use-ftp-tls.yaml
    p4p3r authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    157ae47 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Delete python/lang/security/audit/ftplib.py

    Should have been deleted in #3496, causing semgrep/semgrep-proprietary#2505 to fail
    ajbt200128 authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    116b0bd View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3504 from semgrep/austin/remove-ftplib-py

    Delete python/lang/security/audit/ftplib.py
    ajbt200128 authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2ad051c View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    178f46e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    73d6cde View commit details
    Browse the repository at this point in the history