Skip to content

Commit

Permalink
set IsInjective flag before calling SetNiceMonomorphism (#870)
Browse files Browse the repository at this point in the history
* set `IsInjective` flag before calling `SetNiceMonomorphism`

* Update gap/attributes/isomorph.gi

Co-authored-by: James Mitchell <james-d-mitchell@users.noreply.github.com>
  • Loading branch information
ThomasBreuer and james-d-mitchell authored Sep 17, 2022
1 parent a194195 commit 57420f3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 3 additions & 1 deletion gap/attributes/isomorph.gi
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,9 @@ function(S)
map(p),
map(p ^ -1)));
H := Group(Y);
SetNiceMonomorphism(H, GroupHomomorphismByImagesNC(H, G, Y, X));
map := GroupHomomorphismByImagesNC(H, G, Y, X);
SetIsBijective(map, true);
SetNiceMonomorphism(H, map);
SetIsHandledByNiceMonomorphism(H, true);
UseIsomorphismRelation(H, G);
return H;
Expand Down
1 change: 1 addition & 0 deletions gap/attributes/isorms.gi
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,7 @@ function(G)
G,
GeneratorsOfGroup(H),
GeneratorsOfGroup(G)));
SetIsBijective(iso, true);
SetNiceMonomorphism(G, iso);
SetIsHandledByNiceMonomorphism(G, true);
UseIsomorphismRelation(G, H);
Expand Down

0 comments on commit 57420f3

Please sign in to comment.