Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LeftSemigroupIdeal and RightSemigroupIdeal #1009

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

Jun2M
Copy link
Contributor

@Jun2M Jun2M commented Mar 26, 2024

A pull request for #939.
Implements LeftSemigroupIdeal using a LeftMagmaIdeal and RightSemigroupIdeal as a RightMagmaIdeal.

DeclareGlobalFunction("SemigroupIdeal");
DeclareGlobalFunction("LeftSemigroupIdeal");
DeclareGlobalFunction("RightSemigroupIdeal");
DeclareGlobalFunction("AnySemigroupIdealInputParsing");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DeclareGlobalFunction("AnySemigroupIdealInputParsing");
DeclareGlobalFunction("AnySemigroupIdealInputParsing");

I'd suggest removing this from here, and instead doing

BindGlobal("_AnySemigroupIdealInputParsing", ...)

in the .gi file instead. Note also the _ in the name (either do this or just put the function into the record SEMIGROUPS, by doing:

SEMIGROUPS.AnySemigroupIdealInputParsing := function(...

again in the .gi file. Same goes for all of the "internal" functions that start with "Any"

InstallGlobalFunction(SemigroupIdeal,
function(arg...)
InstallGlobalFunction(AnySemigroupIdealInputParsing,
function(inputArgs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to stick to arg... and whenever you want to call this function do:

CallFuncList(AnySemigroup..., arg);

this is like doing

AnySemigroup...(*arg)

in python

Copy link
Collaborator

@james-d-mitchell james-d-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few very minor changes, and some tests and I'll be happy to merge this!

@james-d-mitchell james-d-mitchell added the new-feature A label for PRs that contain new features label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A label for PRs that contain new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants