Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semidp.tst for compatibility with future GAP version #566

Merged

Conversation

wilfwilson
Copy link
Collaborator

I have created PR gap-system/gap#3053 for GAP, which adds additional properties that are transferred from the factors of a direct product to the direct product, at creation.

This means that, once this is merged, many direct products will know more about themselves at creation than they currently do. This means the test output in semidp.tst and semidp.xml needs to be updated. However, since we still need to support previous versions of GAP, we can't just update the files with the new output. We have to make sure that the properties are definitely computed before viewing the direct product, and showing the new output. That's why there are lots of new calls to IsRegularSemigroup, etc.

The tests on the GAP stable-4.10, 64-bit Travis job will fail until #565 is fixed and merged.

@james-d-mitchell
Copy link
Collaborator

@wilfwilson rerunning the CI now.

@wilfwilson
Copy link
Collaborator Author

The corresponding PR for GAP has been merged, faster than I expected, so I think I have to merge this now to stop the Travis tests going crazy.

@wilfwilson wilfwilson merged commit d50a94a into semigroups:stable-3.1 Nov 26, 2018
@wilfwilson wilfwilson deleted the update-semidp-testoutput branch November 26, 2018 11:38
@olexandr-konovalov
Copy link
Contributor

@wilfwilson this should NOT go to Semigroups release intended for GAP 4.10.1, isn't it?

@wilfwilson
Copy link
Collaborator Author

Thank you for the concern @alex-konovalov, but you are mistaken, this PR hasn't broken backwards compatibility. Semigroups remains compatible with GAP stable-4.9, stable-4.10, and master branches: see for instance https://travis-ci.org/gap-packages/Semigroups/builds/459705352 which is a build containing the current stable-3.1 branch of Semigroups (into which this PR has been merged). You can see that we test against stable-4.9, stable-4.10, and master, and the tests are (I hope!) passing for all of those.

@olexandr-konovalov
Copy link
Contributor

@wilfwilson thanks, that's reassuring!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants