Fix issue 556 #607
Merged
Fix issue 556 #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit partially resolves Issue semigroups#556 by removing the implication that groups belong to `IsEnumerableSemigroupRep`. Other such implications remain, and should be removed. The remaining implications will be removed in a more major clean up (hopefully) in the coming months.
james-d-mitchell
force-pushed
the
fix-issue-556
branch
from
5e29a28
to
afe7ffc
Compare
|
Not trying to hurry you @wilfwilson but in case you didn't see this earlier, I requested your review of this PR. |
wilfwilson
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
Thanks for the reminder @james-d-mitchell, I had overlooked this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially fixes Issue #556, by removing the implication
IsFinite and IsGroup=>IsEnumerableSemigroupRep. Other such implications remain, and should be removed. The remaining implications will be removed in a more major clean up (hopefully) in the coming months.