libzfsbootenv: lzbe_set_boot_device(): don't free undefined pointer

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#11993
sempervictus · May 31, 2021 · f575597 · f575597
1 parent 0fe4c34
commit f575597
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/lib/libzfsbootenv/lzbe_device.c b/lib/libzfsbootenv/lzbe_device.c
@@ -88,12 +88,11 @@ lzbe_set_boot_device(const char *pool, lzbe_flags_t flag, const char *device)
 		if (strncmp(device, "zfs:", 4) == 0) {
 			fnvlist_add_string(nv, OS_BOOTONCE, device);
 		} else {
-			descriptor = NULL;
-			if (asprintf(&descriptor, "zfs:%s:", device) > 0)
+			if (asprintf(&descriptor, "zfs:%s:", device) > 0) {
 				fnvlist_add_string(nv, OS_BOOTONCE, descriptor);
-			else
+				free(descriptor);
+			} else
 				rv = ENOMEM;
-			free(descriptor);
 		}
 	}