Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #122 #123

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix issue #122 #123

merged 1 commit into from
Aug 31, 2023

Conversation

dcrowe
Copy link

@dcrowe dcrowe commented Aug 30, 2023

pyubx2 Pull Request Template

Description

Fixes #122

Testing

Tests have been run, but there don't appear to be any tests covering this change. Would you like a regression test added?

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin self-assigned this Aug 30, 2023
@semuadmin semuadmin added the bug Something isn't working label Aug 30, 2023
@semuadmin
Copy link
Contributor

semuadmin commented Aug 30, 2023

@dcrowe

Thanks for the contribution - much appreciated. I've merged your PR into RC 1.2.30. There is already a test of MON-RF parsing in test_stream.py (testMONLOG) but unfortunately it contains a jammingState value of 0 so didn't show up the issue.

I note also that the attribute currently defined as jamInd is referred to as cwSuppression in later versions, but I'll retain the existing name to minimise regression impact.

If you happen to have a real raw binary datastream containing a UBX MON-RF with a jammingState > 1, I'd be grateful if you could send me it and I'll add it to the test scripts - otherwise I can synthesize one. Thanks.

@semuadmin semuadmin added this to the RC 1.2.30 milestone Aug 30, 2023
@semuadmin semuadmin merged commit f1ee137 into semuconsulting:master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta-data for "MON-RF.group.flags.jammingState" is incorrect. It is specified as U1 when it should be U2.
2 participants