Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC 1.2.48 #167

Merged
merged 2 commits into from
Nov 7, 2024
Merged

RC 1.2.48 #167

merged 2 commits into from
Nov 7, 2024

Conversation

semuadmin
Copy link
Contributor

@semuadmin semuadmin commented Nov 7, 2024

pyubx2 Pull Request Template

Description

  1. Add helper methods val2twoscomp and val2signmag to convert signed integer to appropriate two's complement or sign magnitude binary representation. Can be helpful when populating UBX ESF-MEAS dataField values such as speed or wheel tick, as these use both varieties of signed integer representation.

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

If you're adding new UBX message definitions for Generation 9+ devices, please check for any corresponding configuration database updates (ubxtypes_configdb.py).

  • tests added to test_static.py

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the enhancement New feature or request label Nov 7, 2024
@semuadmin semuadmin added this to the RC 1.2.48 milestone Nov 7, 2024
@semuadmin semuadmin self-assigned this Nov 7, 2024
@semuadmin semuadmin marked this pull request as draft November 7, 2024 10:10
@semuadmin semuadmin marked this pull request as ready for review November 7, 2024 20:07
@semuadmin semuadmin requested a review from a team November 7, 2024 20:07
@semuadmin semuadmin merged commit d79c4d8 into master Nov 7, 2024
5 checks passed
@semuadmin semuadmin deleted the RC-1.2.48 branch November 7, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants