Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate recent changes in index to v2.0.0 #403

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

danny0838
Copy link
Contributor

@danny0838 danny0838 commented Jan 1, 2023

Sync v2.0.0.md with index.md

@JohnTitor
Copy link
Member

@hwhsu1231 Thank you for working on #401! Could you review this PR?

@hwhsu1231
Copy link

@JohnTitor - OK! I'll take some time to write my review these days.

@danny0838
Copy link
Contributor Author

@JohnTitor @hwhsu1231 Just a note: This PR has nothing fancy but simply a fix of previous d3191ef, d1389ac, and 1d996e7, which have missed to edit lang/zh-TW/spec/v2.0.0.md. This can be quickly confirmed by checking whether lang/zh-TW/index.md and lang/zh-TW/spec/v2.0.0.md are identical through diffing them.

- Fix missing changes of `lang/zh-TW/spec/v2.0.0.md` in d3191ef, d1389ac, and 1d996e7.
@danny0838 danny0838 changed the title Populate recent changes in index to v2.0.0 Propagate recent changes in index to v2.0.0 Jan 5, 2023
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I missed the message on the OP. LGTM :)

@JohnTitor JohnTitor merged commit b44bda3 into semver:gh-pages Jan 5, 2023
@danny0838 danny0838 deleted the fix-zh-tw branch January 6, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants