Support for Multiple component analysis #2120
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
Traceback (innermost last):
Module ZPublisher.WSGIPublisher, line 176, in transaction_pubevents
Module ZPublisher.WSGIPublisher, line 385, in publish_module
Module ZPublisher.WSGIPublisher, line 288, in publish
Module ZPublisher.mapply, line 85, in mapply
Module ZPublisher.WSGIPublisher, line 63, in call_object
Module senaite.app.listing.view, line 236, in __call__
Module senaite.app.listing.ajax, line 112, in handle_subpath
Module senaite.core.decorators, line 22, in decorator
Module senaite.app.listing.decorators, line 63, in wrapper
Module senaite.app.listing.decorators, line 50, in wrapper
Module senaite.app.listing.decorators, line 100, in wrapper
Module senaite.app.listing.ajax, line 533, in ajax_transitions
Module senaite.app.listing.ajax, line 225, in get_allowed_transitions_for
Module senaite.app.listing.ajax, line 186, in get_transitions_for
Module bika.lims.api, line 1076, in get_transitions_for
Module Products.CMFPlone.WorkflowTool, line 107, in getTransitionsFor
Module Products.DCWorkflow.DCWorkflow, line 395, in _checkTransitionGuard
Module Products.DCWorkflow.Guard, line 93, in check
Module Products.CMFCore.Expression, line 53, in __call__
Module Products.PageTemplates.ZRPythonExpr, line 49, in __call__
- __traceback_info__: here.guard_handler("verify")
Module PythonExpr, line 1, in <module>
Module Products.CMFCore.FSPythonScript, line 134, in __call__
Module Shared.DC.Scripts.Bindings, line 335, in __call__
Module Shared.DC.Scripts.Bindings, line 372, in _bindAndExec
Module Products.PythonScripts.PythonScript, line 349, in _exec
Module script, line 2, in guard_handler
- <FSPythonScript at /senaite/guard_handler used for /senaite/clients/client-19/23AA047/ICP>
- Line 2
Module bika.lims.workflow, line 370, in guard_handler
Module bika.lims.workflow.analysis.guards, line 83, in decorator
Module bika.lims.workflow.analysis.guards, line 292, in guard_verify
Module bika.lims.workflow.analysis.guards, line 547, in is_verified_or_verifiable
Module bika.lims.workflow.analysis.guards, line 494, in is_transition_allowed
Module bika.lims.workflow.analysis.guards, line 496, in is_transition_allowed
Module plone.memoize.volatile, line 74, in replacement
Module bika.lims.workflow.analysis.guards, line 527, in cached_is_transition_allowed
Module bika.lims.workflow, line 233, in isTransitionAllowed
Module Products.DCWorkflow.DCWorkflow, line 256, in isActionSupported
Module Products.DCWorkflow.DCWorkflow, line 395, in _checkTransitionGuard
...
Module Products.DCWorkflow.Guard, line 93, in check
Module Products.CMFCore.Expression, line 53, in __call__
Module Products.PageTemplates.ZRPythonExpr, line 49, in __call__
- __traceback_info__: here.guard_handler("verify")
RuntimeError: maximum recursion depth exceeded in cmp
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request adds the Multiple Component analysis. Spectroscopic methods are common analytical methods for which multiple component analysis is used, like are Atomic Absorption Spectroscopy (AAS), Inductively Coupled Plasma Spectroscopy (ICP) or Ultraviolet and Visible (UV). Basically, the concentration of individual components/analytes is detected simultaneously, with a single analyzer.
Creation of an Multicomponent Analysis Service:
Selection of analytes on Sample creation:
Multicomponent analyses in worksheet:
Multicomponent analyses in sample:
Current behavior before PR
SENAITE does not support multi-component analysis. Lab is forced to create an individual Analysis Service for every analyte/component
Desired behavior after PR is merged
SENAITE does support multi-component analysis. Analytes can be defined as components of a single Analysis Service
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.