-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance for sample listing index #2273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
approved these changes
Mar 13, 2023
Hi @toropok, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR improves the performance of the
listing_searchable_text
ZCTextIndex of the sample catalog by adding only explicit terms into the index, instead of all the metadata columns defined.Currently, the following values are part of the index:
This improves the performance by
10%
when creating new samples.Furthermore, the stop words are kept in the Lexicon.
Current behavior before PR
All metadata columns are used for the sample
listing_searchable_text
indexDesired behavior after PR is merged
Only the above mentioned values are used for the
listing_searchable_text
index--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.