Fix wrong result when "Result options" with "String result" setting enabled #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request fixes an issue introduced with #2259 that makes the system to display the result option value (instead of the text) for analyses that have "Result options" properly configured, but with the "String results" setting enabled as well.
With this Pull Request, system gives priority to the fact that the analysis has "Result option" values properly configured over the "String results" setting.
Current behavior before PR
After the result is submitted for an analysis with result options and "String results" setting enabled, the system displays the value of the selected option:
Desired behavior after PR is merged
After the result is submitted for an analysis with result options and "String results" setting enabled, the system displays the text of the selected option:
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.