-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Senaite labels #2276
Merged
Merged
Senaite labels #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR introduces labels for SENAITE:
Basically all AT/DX contents can be configured to have labels via the SENAITE registry, unless they define their schema solely over a behavior, e.g. a
DataBox
.In this case, the extended label field does not appear in the edit view, but the contents can be still labeled programmatically with the provided Label API.
The extended label field queries existing labels that have been created in the "Labels" setup folder, but allow also to enter arbitrary labels for a specific object.
Object labels are stored in the annotation storage to avoid attribute clashes and define extend the following field to the object:
ExtLabels
ext_labels
When a label is assigned to an object, the object will be cataloged in the
senaite_catalog_label
catalog.The
labels
index allows to search for all labeled objects in SENAITE.Current behavior before PR
No labels available
Desired behavior after PR is merged
All objects can be labeled
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.