Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all custom transitions in sample report listing #2279

Merged
merged 132 commits into from
Mar 29, 2023
Merged

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Mar 27, 2023

Description of the issue/feature this PR addresses

Please merge #2278 first

This PR allows the same transitions for reports listings below samples as in the reports listing at client level.

Furthermore, it adds the missing KeywordIndex sample_uid to the report catalog and shows the transitions based on the required permissions.

Current behavior before PR

Report listing view below samples showed only the email transition

Desired behavior after PR is merged

Report listing view below samples shows the same transitions as in client report listing

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa March 27, 2023 11:44
@ramonski ramonski added Bug 🐞 Improvement 🔧 Cleanup 🧹 Code cleanup and refactoring labels Mar 27, 2023
@xispa xispa merged commit ab21227 into 2.x Mar 29, 2023
@xispa xispa deleted the sample-report-listing branch March 29, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants