Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom date rendering in sample header #2280

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR removes the custom rendering of date fields in the sample header and delegates to the widget.

Current behavior before PR

Custom date field rendering

Desired behavior after PR is merged

Date rendering is done by the widget

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa March 27, 2023 14:08
@ramonski ramonski added the Cleanup 🧹 Code cleanup and refactoring label Mar 27, 2023
@xispa xispa merged commit c5cce78 into 2.x Mar 27, 2023
@xispa xispa deleted the sampleheader-date-widget-rendering branch March 30, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup 🧹 Code cleanup and refactoring
Development

Successfully merging this pull request may close these issues.

2 participants