Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the email sent on sample rejection is not text/html #2284

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

xispa
Copy link
Member

@xispa xispa commented Mar 29, 2023

Description of the issue/feature this PR addresses

This Pull Request ensures the content type of the body of the email that is sent automatically to the client contact on sample rejection is text/html.

Current behavior before PR

225860665-b555824e-88c7-4b7c-bd4e-b21d4d5ecaaa

Desired behavior after PR is merged

HTML elements are rendered accordingly

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa changed the title Fix the body of the rejection email is not sent as html Fix the email sent on sample rejection is not text/html Mar 29, 2023
@xispa xispa requested a review from ramonski March 29, 2023 09:50
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Just a minor typo to fix

src/senaite/core/tests/doctests/API_mail.rst Show resolved Hide resolved
@xispa xispa added the Bug 🐞 label Mar 29, 2023
@ramonski ramonski merged commit 151de01 into 2.x Mar 29, 2023
@ramonski ramonski deleted the fix-rejection-email branch March 29, 2023 10:02
@xispa xispa added the To port label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants