Properly process and validate field values from sample header on submit #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request ensures the data submitted in Sample's header viewlet is properly processed by the widget and validated afterwards
Current behavior before PR
widget's
process_formis not used to process the field value submitted in the form, so field validators do not receive the expected data, causing them to either fail or the validation to be ignored. This also causes the need of adding custom subscriberson_object_editedto properly handle the values (e.g.: https://github.com/senaite/senaite.patient/blob/6e41d9c169e8e35dd1bb25a46df08754942f8b32/src/senaite/patient/subscribers/analysisrequest.py#L62-L69)Desired behavior after PR is merged
widget's
process_formis used to process the field value submitted in the form, so field validators always receive the expected data--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.