Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply dynamic analyses specs for new added analyses #2315

Merged
merged 7 commits into from
May 29, 2023

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR applies dynamic analyses specs for new added analyses

Current behavior before PR

Dynamic Analysis Specifications only applied to Analyses when the Specification is assigned to the Sample.

Desired behavior after PR is merged

Dynamic Analysis Specifications applied to Analyses when the Specification is assigned to the Sample and when new Analyses are added to the Sample

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa May 28, 2023 10:28
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this hidden one!

@xispa xispa merged commit 8bac862 into 2.x May 29, 2023
@xispa xispa deleted the sample-manage-analyses-apply-dynamic-specs branch May 29, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants