Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on sample copy when fields are hidden #2344

Merged
merged 4 commits into from
Jun 25, 2023

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR fixes an issue in the sample add form when the following fields are hidden:

  • CC Contacts
  • Attachments
  • Analysis Profiles

Current behavior before PR

Error occurs and sample can not be created

Desired behavior after PR is merged

Samples get created when fields are hidden

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa June 24, 2023 18:34
@xispa xispa merged commit 774efd3 into 2.x Jun 25, 2023
2 checks passed
@xispa xispa deleted the fix-sample-copy-with-hidden-fields branch June 25, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants