Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError if registry key not found #2361

Merged
merged 3 commits into from
Aug 19, 2023
Merged

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR fixes a KeyError if a registry was not found in SENAITE registry.

Current behavior before PR

KeyError occured:

Traceback (innermost last):
  Module ZPublisher.WSGIPublisher, line 176, in transaction_pubevents
  Module ZPublisher.WSGIPublisher, line 385, in publish_module
  Module ZPublisher.WSGIPublisher, line 288, in publish
  Module ZPublisher.mapply, line 85, in mapply
  Module ZPublisher.WSGIPublisher, line 63, in call_object
  Module senaite.app.listing.view, line 253, in __call__
  Module Products.Five.browser.pagetemplatefile, line 126, in __call__
  Module Products.Five.browser.pagetemplatefile, line 61, in __call__
  Module zope.pagetemplate.pagetemplate, line 135, in pt_render
  Module Products.PageTemplates.engine, line 378, in __call__
  Module z3c.pt.pagetemplate, line 176, in render
  Module chameleon.zpt.template, line 302, in render
  Module chameleon.template, line 192, in render
  Module 7e72112bcf4a9afe1cacbff1c4bb3ccb, line 321, in render
  Module 5d335aff98fbc4f482a851a9b988273a, line 1428, in render_master
  Module 5d335aff98fbc4f482a851a9b988273a, line 407, in render_content
  Module 7e72112bcf4a9afe1cacbff1c4bb3ccb, line 259, in __fill_content_core
  Module zope.tales.expressions, line 250, in __call__
  Module Products.PageTemplates.Expressions, line 225, in _eval
  Module Products.PageTemplates.Expressions, line 155, in render
  Module senaite.app.listing.view, line 331, in contents_table
  Module Products.Five.browser.pagetemplatefile, line 126, in __call__
  Module Products.Five.browser.pagetemplatefile, line 61, in __call__
  Module zope.pagetemplate.pagetemplate, line 135, in pt_render
  Module Products.PageTemplates.engine, line 378, in __call__
  Module z3c.pt.pagetemplate, line 176, in render
  Module chameleon.zpt.template, line 302, in render
  Module chameleon.template, line 215, in render
  Module chameleon.template, line 192, in render
  Module d4f00f9ce29148f0dbffd965c8491481, line 418, in render
  Module zope.tales.pythonexpr, line 73, in __call__
   - __traceback_info__: (view.ajax_transitions_enabled())
  Module <string>, line 1, in <module>
  Module plone.memoize.view, line 59, in memogetter
  Module senaite.app.listing.decorators, line 50, in wrapper
  Module senaite.app.listing.ajax, line 321, in ajax_transitions_enabled
  Module senaite.core.registry, line 67, in get_registry_record
  Module plone.registry.registry, line 82, in forInterface
KeyError: 'Interface `senaite.app.listing.controlpanel.IListingRegistry` defines a field `listing_active_ajax_transitions`, for which there is no record.'

Desired behavior after PR is merged

Error is only logged.

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa August 19, 2023 08:00
@xispa xispa merged commit 660dfa7 into 2.x Aug 19, 2023
2 checks passed
@xispa xispa deleted the avoid-senaite-registry-keyerror branch August 19, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants