Auto-hide non-multivalued reference widget input on value selection #2363
Conversation
| @@ -112,8 +111,6 @@ def get_input_widget_attributes(self, context, field, value): | |||
| "data-multi_valued": getattr(self, "multi_valued", True), | |||
| "data-disabled": getattr(self, "disabled", False), | |||
| "data-readonly": getattr(self, "readonly", False), | |||
| "data-hide_input_after_select": getattr( | |||
| self, "hide_input_after_select", True), | |||
There was a problem hiding this comment.
Please also remove the attribute from the DX version:
senaite.core/src/senaite/core/z3cform/widgets/queryselect/widget.py
Lines 163 to 164 in f351348
| form[name=analysisrequest_add_form] { | ||
| .field { | ||
| margin-bottom: 0; | ||
| } |
There was a problem hiding this comment.
Not sure why this is here inside. Also I do not see any DOM elements in the add form with a class="field" at the moment.
| @@ -76,7 +76,7 @@ class SelectedValues extends React.Component { | |||
| <button value={value} | |||
| data-toggle="confirmation" | |||
| data-title={_t("Unlink reference?")} | |||
| className="btn btn-sm btn-link-danger" | |||
| className="btn btn-sm p-0 ml-2" | |||
There was a problem hiding this comment.
This one is cool. Makes the whole item smaller. Thanks for this one.
| if (this.state.readonly) { | ||
| return false; | ||
| } | ||
| if (!this.state.multi_valued && this.state.values.length > 0) { | ||
| return false; |
There was a problem hiding this comment.
Not sure about this. Probably the last line needs to be first to keep the input widget visible, even if it is readonly/disabled.
Or maybe just return True if this.state.multi_valued?
There was a problem hiding this comment.
Why one would want the input element to be displayed if it cannot be used (because is disabled or readonly)?
There was a problem hiding this comment.
Hmm, good point. To see that it is disabled by purpose maybe?
xispa
changed the title
Description of the issue/feature this PR addresses
This Pull Request improves the styling of the Reference widget and hides the select input text when there is a value selected and the reference widget is not multiValued (the
hide_input_after_selectattribute is no longer necessary).Current behavior before PR
Sample add form:
Sample view form:
Desired behavior after PR is merged
Sample add form
Sample view form
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.