Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New function for interim fields formatting #2365

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Conversation

xispa
Copy link
Member

@xispa xispa commented Aug 25, 2023

Description of the issue/feature this PR addresses

This Pull Request adds a function to make the formatting of interim fields easier. It also adds a new function to_list in the api

Current behavior before PR

Formatting values and units of interim fields for human visualization is cumbersome

Desired behavior after PR is merged

Formatting values and units of interim fields for human visualization made easy

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

pass
if not isinstance(value, (list, tuple, set)):
value = [value]
return list(value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this function into 2, e.g. something like this:

def parse_json(thing, default=""):
    """Parse from JSON
    """
    try:
        return json.loads(thing)
    except (TypeError, ValueError):
        return default

def to_list(value):
    """Converts the value to a list
    :param value: the value to be represented as a list
    :returns: a list that represents or contains the value
    """
    if is_string(value):
        value = parse_json(value, [])
    if not isinstance(value, (list, tuple, set)):
        value = [value]
    return list(value)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with 4134d9b

@ramonski
Copy link
Contributor

Only a minor thing to increase reusability

@ramonski ramonski merged commit 83455a9 into 2.x Aug 25, 2023
2 checks passed
@ramonski ramonski deleted the interim-fields-formatting branch August 25, 2023 11:58
@grulisco
Copy link
Contributor

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants