-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New function for interim fields formatting #2365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
requested changes
Aug 25, 2023
pass | ||
if not isinstance(value, (list, tuple, set)): | ||
value = [value] | ||
return list(value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this function into 2, e.g. something like this:
def parse_json(thing, default=""):
"""Parse from JSON
"""
try:
return json.loads(thing)
except (TypeError, ValueError):
return default
def to_list(value):
"""Converts the value to a list
:param value: the value to be represented as a list
:returns: a list that represents or contains the value
"""
if is_string(value):
value = parse_json(value, [])
if not isinstance(value, (list, tuple, set)):
value = [value]
return list(value)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with 4134d9b
Only a minor thing to increase reusability |
ramonski
approved these changes
Aug 25, 2023
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request adds a function to make the formatting of interim fields easier. It also adds a new function
to_list
in the apiCurrent behavior before PR
Formatting values and units of interim fields for human visualization is cumbersome
Desired behavior after PR is merged
Formatting values and units of interim fields for human visualization made easy
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.