Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact catalog #2367

Merged
merged 14 commits into from
Aug 30, 2023
Merged

Contact catalog #2367

merged 14 commits into from
Aug 30, 2023

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR introduces a new catalog for Contact, LabContact and SupplierContact.

Current behavior before PR

Contact is still indexed in portal_catalog and LabContact and SupplierContact are in senaite_catalog_setup.

Desired behavior after PR is merged

All contact types are indexed in the ContactCatalog

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski added Improvement 🔧 Cleanup 🧹 Code cleanup and refactoring labels Aug 28, 2023
@ramonski ramonski requested a review from xispa August 28, 2023 13:16
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@xispa xispa merged commit aa083b8 into 2.x Aug 30, 2023
2 checks passed
@xispa xispa deleted the contact-catalog branch August 30, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup 🧹 Code cleanup and refactoring Improvement 🔧
Development

Successfully merging this pull request may close these issues.

2 participants