Allow to set a custom comment for when a result is out of range #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
changed the title
ramonski
requested changes
Sep 1, 2023
| u"indicate a shoulder range. " | ||
| u"Any result outside the results range but within the " | ||
| u"shoulder range will raise a less severe alert. " | ||
| u"If the result is out of range, the value set for " |
There was a problem hiding this comment.
somehow the description in the UI is cropped at this point (Maybe because of the starting single quote in the next line?).
There was a problem hiding this comment.
Cannot reproduce 🤔 . It is displayed correctly to me:
There was a problem hiding this comment.
Even when I shrink the window:
There was a problem hiding this comment.
Hmm, it does not seem like a browser issue, because the text is even cropped in the HTML:
It appears to me even for new created sites when adding a new specification.
There was a problem hiding this comment.
Umm..
These are my versions:
ramonski
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request enables the existing
rangecommentfield, so when has a value set, the system displays that value in results report in accordance. It also makes the default edit form styling to not apply on listings (otherwise, the specs widget is not usable).Current behavior before PR
Is not possible to display a custom text in results report when the result is out of range
Desired behavior after PR is merged
Is possible to display a custom text in results report when the result is out of range
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.