Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic search index lookup for referencewidget and added default catalog metadata columns #2386

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR adds the ability to dynamically lookup a suitable ZCTextIndex for reference widgets and adds default columns to the search catalogs.

Current behavior before PR

  • Title was always used if no search_index was defined in the widget
  • Missing metadata columns in search catalogs

Desired behavior after PR is merged

  • Dynamic index lookup is performed to find one of the following indexes:
    • <portal_type>_searchable_text
    • listing_searchable_text
    • Title
  • Additional metadata columns added to the search catalogs

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski changed the title Add dynamic search index lookup for referencewidget and additional metadata columns Add dynamic search index lookup for referencewidget and added default catalog metadata columns Sep 14, 2023
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@xispa xispa merged commit fa02b54 into 2.x Sep 14, 2023
2 checks passed
@xispa xispa deleted the referencewidget-search-indexes branch September 14, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants