Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QC sample IDs are the same accross worksheets #2388

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

Linked issue: #2289

Current behavior before PR

Reference and Duplicate analyses missed getReferenceAnalysesGroupID index

Desired behavior after PR is merged

Reference and Duplicate analyses reindexed including getReferenceAnalysesGroupID index

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for driving into this mess

@xispa xispa merged commit 68363e6 into 2.x Sep 21, 2023
2 checks passed
@xispa xispa deleted the reindex-reference-analyses branch September 21, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants