Fix sample specs get overwritten on manage analyses save #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
changed the title
ramonski
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request prevents the message "Ranges for some analyses are different from the Specification" to be displayed when adding analyses manually on a Sample with specifications already set and with the setting "Enable Sample Specifications" disabled. The message "result range is different from specification" is also displayed next to analyses.
If the setting "Enable Sample Specifications" is disabled, the system must not overwrite the specifications set for a given analysis through the "Specification" field.
Current behavior before PR
Sample results ranges are overwritten when adding analyses manually, even though the setting "Enable Sample Specifications" is disabled.
Desired behavior after PR is merged
Sample results ranges are not overwritten when adding analyses manually and with the setting "Enable Sample Specifications" disabled.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.