Check permission when automatic sample reception is enabled #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xispa
approved these changes
Nov 12, 2023
xispa
deleted the
fix-permission-check-for-automatic-sample-reception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Linked issue: #2418
This PR fixes a permission issue when automatic sample reception is enabled in the setup
Current behavior before PR
Samples are always transitioned to
sample_receive, no matter if the user has the permissionsenaite.core: Transition: Receive Samplegranted or not.Desired behavior after PR is merged
Samples are only transitioned to
sample_receiveif the user has the permissionsenaite.core: Transition: Receive Samplegranted.--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.