Fix worksheets are not uncatalogued when deleted #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
reviewed
Dec 20, 2023
| if obj is None: | ||
| # object is missing, remove | ||
| logger.info("Removing stale record: {}".format(path)) | ||
| cat.uncatalog_object(path) |
There was a problem hiding this comment.
should this be api.uncatalog_object instead?
There was a problem hiding this comment.
No, because we don't have an object here, but a path. api.uncatalog_object expects an object
There was a problem hiding this comment.
Ah, you are right, thanks!
ramonski
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Requests ensures that when removing a Worksheet, the object is uncatalogued as well. Besides, this PR adds some functions in the API and an upgrade step to purge stale worksheets
Current behavior before PR
When deleting a Worksheet (w/o analyses), the system does not uncatalog the worksheet
Desired behavior after PR is merged
When deleting a Worksheet (w/o analyses), the system does uncatalog the worksheet
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.