-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default landing page is not considered in clients listing #2459
Conversation
This whole dance is not worth. Closing |
Re-opening this one because of legacy compatibility. We'll need to revisit this landing page thing at some point though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jordi!
Just one thing:
Can you move the key "client_landing_page" into the config as a variable?
Please also add our |
Done with 6f6f89d |
Done with e4926a5 |
Description of the issue/feature this PR addresses
This Pull Request fixes the default landing page when a client from the folder listing is selected as well as when a client login the system and no default wide landing page is set in classic setup.
This functionality was once provided by means of the registry record with key
bika.lims.client.default_landing_page
, that is no longer available in 2.x instances, but in those upgraded from 1.xThe setting is now available under SENAITE Registry:
Current behavior before PR
The legacy setting for the default landing page is no longer used
Desired behavior after PR is merged
The legacy setting for the default landing page is ported to SENAITE registry
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.