Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default landing page is not considered in clients listing #2459

Merged
merged 10 commits into from
Dec 29, 2023

Conversation

xispa
Copy link
Member

@xispa xispa commented Dec 28, 2023

Description of the issue/feature this PR addresses

This Pull Request fixes the default landing page when a client from the folder listing is selected as well as when a client login the system and no default wide landing page is set in classic setup.

This functionality was once provided by means of the registry record with key bika.lims.client.default_landing_page, that is no longer available in 2.x instances, but in those upgraded from 1.x

The setting is now available under SENAITE Registry:

Captura de 2023-12-28 19-16-32

Current behavior before PR

The legacy setting for the default landing page is no longer used

Desired behavior after PR is merged

The legacy setting for the default landing page is ported to SENAITE registry

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa marked this pull request as ready for review December 28, 2023 18:18
@xispa xispa requested a review from ramonski December 28, 2023 18:18
@xispa xispa closed this Dec 28, 2023
@xispa
Copy link
Member Author

xispa commented Dec 28, 2023

This whole dance is not worth. Closing

@xispa xispa deleted the fix-client-landing-page branch December 28, 2023 18:25
@xispa xispa restored the fix-client-landing-page branch December 29, 2023 09:41
@xispa
Copy link
Member Author

xispa commented Dec 29, 2023

Re-opening this one because of legacy compatibility. We'll need to revisit this landing page thing at some point though.

@xispa xispa reopened this Dec 29, 2023
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jordi!
Just one thing:
Can you move the key "client_landing_page" into the config as a variable?

@ramonski
Copy link
Contributor

Please also add our @upgradestep(product, version) decorator around the import_registry function. I've seen that add-ons might loose the navigation settings.

@xispa
Copy link
Member Author

xispa commented Dec 29, 2023

Thanks Jordi! Just one thing: Can you move the key "client_landing_page" into the config as a variable?

Done with 6f6f89d

@xispa
Copy link
Member Author

xispa commented Dec 29, 2023

Please also add our @upgradestep(product, version) decorator around the import_registry function. I've seen that add-ons might loose the navigation settings.

Done with e4926a5

@ramonski ramonski merged commit db79728 into 2.x Dec 29, 2023
2 checks passed
@ramonski ramonski deleted the fix-client-landing-page branch December 29, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants