Refactor publish view controls and content table to viewlets #133
Conversation
ramonski
changed the title
|
|
||
|
|
||
| class PublishContentViewlet(ViewletBase): | ||
| """Viewlet that is displayed when the Auditlog is disabled |
There was a problem hiding this comment.
Should be something like "Viewlet that is displayed in the publish view above the publish controls"
| manager=".interfaces.IPublishHtmlHeadViewlets" | ||
| class=".resources.ResourcesViewlet" | ||
| permission="zope2.View" | ||
| layer="senaite.impress.interfaces.ILayer" |
There was a problem hiding this comment.
Why you rely on ILayer instead of ISenaiteImpressLayer? Also, why to not remove the former and leave only the latter in interfaces.py?
There was a problem hiding this comment.
Good point, I changed that in e109cb0
| <td tal:define="state model/review_state|nothing"> | ||
| <span tal:condition="state" | ||
| i18n:translate="" | ||
| i18n:domain="bika" |
There was a problem hiding this comment.
These i18n directives can be removed, span contents won't be translated
There was a problem hiding this comment.
You are right, also the domain was wrong.
I removed it in 8fcbd51
This template will be replaced with a content table of senaite.app.listing in the next PR.
| xmlns:plone="http://namespaces.plone.org/plone" | ||
| xmlns:browser="http://namespaces.zope.org/browser"> | ||
|
|
||
| <include package=".publish" /> |
There was a problem hiding this comment.
ValidationError: ImportError: Module senaite.impress.browser has no global publish
There was a problem hiding this comment.
This will be part of the next PR, sorry for that. Because I had the package already, it did not fail on my side.
Description of the issue/feature this PR addresses
This PR refactors the setup-button, language selector and content listing of the publish view into separate viewlets.
Current behavior before PR
All elements inside the publish view template
Desired behavior after PR is merged
Elements are rendered by viewlets
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.