Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed catalogs in page templates #32

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Conversation

ramonski
Copy link
Contributor

@ramonski ramonski commented Jan 7, 2022

Description of the issue/feature this PR addresses

This PR changes the catalog IDs in the storage templates

Current behavior before PR

Old catalog identifiers used, which resulted in JS errors when searching for samples/storages

Desired behavior after PR is merged

New catalog identifiers used

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa January 7, 2022 08:42
@ramonski ramonski added the bug Something isn't working label Jan 7, 2022
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, this deserves a release by itself

@xispa xispa merged commit a9be86e into 2.x Jan 7, 2022
@xispa xispa deleted the fix-storage-catalogs-in-templates branch January 7, 2022 10:22
@ramonski
Copy link
Contributor Author

ramonski commented Jan 7, 2022

Yes, I am going to release a 2.1.1 today. Unfortunately, things like this always happen after the release 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants