Improve apply_dml_events_validation batch size handling #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two major issues of apply_dml_events_validation
apply_dml_events_validation_batch_size
) of DML events occur within a given time range, the validator attempts to cut the batch size by reducing the range size. However, when the time range is already 1 second, it can’t reduce the time range further because the binlog event timestamp has a 1-second resolution, which causes it to fall into an infinite loop.batch_start_timestamp < end_timestamp
. This had possibility of skipping theend_timestamp
when thebatch_duration
is evaluated as0
Additionally added feature to not run
full_dml_event_validation
iffull_dml_event_validation
is set to0